Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lana feedback edits #349

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Lana feedback edits #349

merged 6 commits into from
Oct 19, 2023

Conversation

LanaStewa
Copy link
Collaborator

@LanaStewa LanaStewa commented Oct 16, 2023

Note: the images aren't displaying because the branch with the new images has not been published.
FN PR: canada-ca/systeme-conception#229

https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when
https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/about-page-feedback

Added images to the how this works page
Added a new on this page section to the "when" page

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for design-system-canada-ca ready!

Name Link
🔨 Latest commit 374987a
🔍 Latest deploy log https://app.netlify.com/sites/design-system-canada-ca/deploys/65317f6e86936f0008cab990
😎 Deploy Preview https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donohuech
Copy link
Contributor

donohuech commented Oct 17, 2023

On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool

There's a "you" in here that should be "your":

Use cases for the page feedback tool
Consider adding the page feedback tool to:

  • uncover specific page-level issues affecting you GC Task Success Survey task score

@donohuech
Copy link
Contributor

donohuech commented Oct 17, 2023

On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool

There is an "is" in here that should be an "if":

Evaluating page success based on yes / no clicks
The feedback tool is biased towards collecting ‘no’ answers in several ways:

  • Humans, by nature, have a negativity bias
  • We are only collecting feedback is someone selects ‘no’
  • If they did find an answer and were successful, they may never have reached the bottom of the page

@donohuech
Copy link
Contributor

donohuech commented Oct 17, 2023

On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool

Missing a period at the end of this paragraph:

Evaluating statistical significance of feedback based on page visits
The number of page visits does not represent the number of people who saw the feedback tool at the bottom of the page or were motivated to use it

@donohuech
Copy link
Contributor

On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/about-page-feedback

Image description for 2b should remove the "in"

After interacting with the “No” button in, a text entry screen will replace the prompt.

In the contact option, there is an expand/collapse pattern with the header “Need urgent help with a problem? Contact us”. When the expand/collapse pattern is opened, there is a customizable link to contact the service.

After the expand/collapse pattern, there is a heading for “Please provide more details” followed by instructions to not include personal information: “You will not receive a reply. Don’t include personal information (telephone, email, SIN financial, medical, or work details. Maximum 300 characters.” There is a small text entry box followed by a button for “Submit”.

Copy link
Contributor

@donohuech donohuech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for some small fixes @LanaStewa

@LanaStewa
Copy link
Collaborator Author

@donohuech Just pushed these edits

@LanaStewa LanaStewa merged commit fb0e2b6 into master Oct 19, 2023
3 checks passed
@LanaStewa LanaStewa deleted the lana-feedback-edits branch October 19, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants